Change in openvpn[master]: get_default_gateway(): implement platform support for Linux/SITNL
A message that is not in the archive (sent off-list or not yet received): gerrit.1738260795000.I1db72d7dca648a8ea4ec65d173290a819971305c@...2715...
Attention is currently required from: flichtenheld, plaisthos.
Hello plaisthos, flichtenheld,
I'd like you to do a code review.
Please visit
http://gerrit.openvpn.net/c/openvpn/+/883?usp=email
to review the following change.
Change subject: get_default_gateway(): implement platform support for Linux/SITNL
......................................................................
get_default_gateway(): implement platform support for Linux/SITNL
This adds Linux/SITNL platform functionality to the framework started by commit 9df51cf56 and commit 0fcfc8381f.
---
M src/openvpn/route.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/83/883/1
src/openvpn/route.c +1 -1
@@ -3333,7 +3333,7 @@CLEAR (best_name);/* get default gateway IP addr */ -if (net_route_v4_best_gw (ctx,NULL , &rgi->gateway.addr, best_name) ==0 ) +if (net_route_v4_best_gw (ctx, &dest, &rgi->gateway.addr, best_name) ==0 ) { rgi->flags |=RGI_ADDR_DEFINED ;if (!rgi->gateway.addr && best_name[0 ])
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/883?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c
Gerrit-Change-Number: 883
Gerrit-PatchSet: 1
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newchange
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/883?usp=email
to look at the new patch set (#2).
Change subject: get_default_gateway(): implement platform support for Linux/SITNL
......................................................................
get_default_gateway(): implement platform support for Linux/SITNL
This adds Linux/SITNL platform functionality to the framework started by commit 9df51cf56 and commit 0fcfc8381f.
v2: make comment reflect reality
---
M src/openvpn/route.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/83/883/2
src/openvpn/route.c +2 -2
@@ -3332,8 +3332,8 @@CLEAR (*rgi);CLEAR (best_name); -/* get default gateway IP addr */ -if (net_route_v4_best_gw (ctx,NULL , &rgi->gateway.addr, best_name) ==0 ) +/* find best route to 'dest', get gateway IP addr + interface */ +if (net_route_v4_best_gw (ctx, &dest, &rgi->gateway.addr, best_name) ==0 ) { rgi->flags |=RGI_ADDR_DEFINED ;if (!rgi->gateway.addr && best_name[0 ])
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/883?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c
Gerrit-Change-Number: 883
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-MessageType: newpatchset
Attention is currently required from: cron2, flichtenheld, plaisthos.
ordex has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/883?usp=email )
Change subject: get_default_gateway(): implement platform support for Linux/SITNL
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
/me no like the commit message, but its reference to the other commits should help the casual reader find its way up to the actual motive behind this change.
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/883?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c
Gerrit-Change-Number: 883
Gerrit-PatchSet: 2
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: ordex <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]...>
Gerrit-Attention: cron2 <[email protected]...>
Gerrit-Attention: flichtenheld <[email protected]...>
Gerrit-Comment-Date: Fri, 31 Jan 2025 08:43:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
PATCH v2 1/1 get_default_gateway(): implement platform support for Linux/SITNL
In reply to a message not in the archiveThis adds Linux/SITNL platform functionality to the framework started by commit 9df51cf56 and commit 0fcfc8381f.
v2: make comment reflect reality
---
This change was reviewed on Gerrit and approved by at least one developer. I request to merge it to master.
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/883
This mail reflects revision 2 of this Change.
Acked-by according to Gerrit (reflected above):
Antonio Quartulli <[email protected]...>
src/openvpn/route.c +2 -2
@@ -3332,8 +3332,8 @@CLEAR (*rgi);CLEAR (best_name); -/* get default gateway IP addr */ -if (net_route_v4_best_gw (ctx,NULL , &rgi->gateway.addr, best_name) ==0 ) +/* find best route to 'dest', get gateway IP addr + interface */ +if (net_route_v4_best_gw (ctx, &dest, &rgi->gateway.addr, best_name) ==0 ) { rgi->flags |=RGI_ADDR_DEFINED ;if (!rgi->gateway.addr && best_name[0 ])
[Openvpn-devel] [PATCH applied] Re: get_default_gateway(): implement platform support for Linux/SITNL
Tested on a local gentoo system, with "the usual" questions (--show-gateway, --show-gateway 127.0.0.1, --show-gateway <on lan>, ...).
Patch has been applied to the master branch.
commit f28c254da58c7a48592c2c63c0a98b38283405e8
Author: Gert Doering Date: Fri Jan 31 09:46:51 2025 +0100
get_default_gateway(): implement platform support for Linux/SITNL
Signed-off-by: Gert Doering <[email protected]...>
Acked-by: Antonio Quartulli <[email protected]...>
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg30749.html
Signed-off-by: Gert Doering <[email protected]...>--
kind regards,
Gert Doering
Hello flichtenheld, ordex, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/883?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+2 by ordex
Change subject: get_default_gateway(): implement platform support for Linux/SITNL
......................................................................
get_default_gateway(): implement platform support for Linux/SITNL
This adds Linux/SITNL platform functionality to the framework started by commit 9df51cf56 and commit 0fcfc8381f.
v2: make comment reflect reality
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg30749.html
---
M src/openvpn/route.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/83/883/3
src/openvpn/route.c +2 -2
@@ -3332,8 +3332,8 @@CLEAR (*rgi);CLEAR (best_name); -/* get default gateway IP addr */ -if (net_route_v4_best_gw (ctx,NULL , &rgi->gateway.addr, best_name) ==0 ) +/* find best route to 'dest', get gateway IP addr + interface */ +if (net_route_v4_best_gw (ctx, &dest, &rgi->gateway.addr, best_name) ==0 ) { rgi->flags |=RGI_ADDR_DEFINED ;if (!rgi->gateway.addr && best_name[0 ])
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/883?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c
Gerrit-Change-Number: 883
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: ordex <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: newpatchset
cron2 has submitted this change. ( http://gerrit.openvpn.net/c/openvpn/+/883?usp=email )
Change subject: get_default_gateway(): implement platform support for Linux/SITNL
......................................................................
get_default_gateway(): implement platform support for Linux/SITNL
This adds Linux/SITNL platform functionality to the framework started by commit 9df51cf56 and commit 0fcfc8381f.
v2: make comment reflect reality
Message-Id: <[email protected]...>
URL: https://www.mail-archive.com/[email protected]/msg30749.html
---
M src/openvpn/route.c
1 file changed, 2 insertions(+), 2 deletions(-)
src/openvpn/route.c +2 -2
@@ -3332,8 +3332,8 @@CLEAR (*rgi);CLEAR (best_name); -/* get default gateway IP addr */ -if (net_route_v4_best_gw (ctx,NULL , &rgi->gateway.addr, best_name) ==0 ) +/* find best route to 'dest', get gateway IP addr + interface */ +if (net_route_v4_best_gw (ctx, &dest, &rgi->gateway.addr, best_name) ==0 ) { rgi->flags |=RGI_ADDR_DEFINED ;if (!rgi->gateway.addr && best_name[0 ])
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/883?usp=email
To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I1db72d7dca648a8ea4ec65d173290a819971305c
Gerrit-Change-Number: 883
Gerrit-PatchSet: 3
Gerrit-Owner: cron2 <[email protected]...>
Gerrit-Reviewer: flichtenheld <[email protected]...>
Gerrit-Reviewer: ordex <[email protected]...>
Gerrit-Reviewer: plaisthos <[email protected]...>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-MessageType: merged